Afshin Taylor Darian

Results 133 comments of Afshin Taylor Darian

@krassowski: > I like having the ability to use ctrl + f to find items on a single pager rather than look though multiple pages One convention I've seen to...

@jtpio After thinking it through and discussing it with @blink1073, I think a better model is the following (I'll update the top-level comment as well): * `ServiceManager.getInstance(): ServiceManager.IManager | null`...

> Does that mean we will expect extensions and plugins to use ServiceManager.getInstance() to access the service manager? And do we encourage this practice, or just provide an alternative? This...

> Also wondering how this would work when a custom ServiceManager is provided to the JupyterLab application (or to a different JupyterFrontEnd). Would calling ServiceManager.getInstance() return the custom service manager...

I think the primary original motivation wasn't about consideration of system resources so much as it was about responsiveness. Consider this example somebody created that is very illustrative: https://codepen.io/YOONBYEONGIN/pen/RwxrEPN It...

I should have stated that more strongly: you have

> if one callback gets stuck waiting on an animation frame while other callbacks keep firing with timeouts Hm. You're right, @vidartf. This _is_ possible. I put the PR back...

After a lot of back and forth, this is ready for review.

@vidartf, > Note: The PR was backported to the 1.x branch. Will that be an issue? We will not release a patch release of the 1.x branch until we have...

> Also: leaving myself a note to trace where the `requestAnimationFrame` stuff came from, because I am almost certain it went through the `Poll` path, though it might have gone...