Rajat Mittal

icon company Amazon icon location Seattle, WA icon location Developer

Results 77 comments of Rajat Mittal

Long click on text to start highlighting, for text copying

Due to its capability of rendering PDFs in image format, selecting or highlighting them is impossible. We haven't explored the OCR yet. Thank you

Edit initWithUrl fun to use functional programming in (proInitWithUrl) function

Hi, would you mind cleaning up your PR and rebasing please. Thank you!

Edit initWithUrl fun to use functional programming in (proInitWithUrl) function

Please remove `.idea` from your committed changes as well.

Edit initWithUrl fun to use functional programming in (proInitWithUrl) function

Hey @ahmedfolly, I still see .idea files and conflicts in your commit. Can you please exclude them and resolve them? Thank you!

Add jumpToPage functionality to Compose wrapper

Hi Could you please resolve conflicts?

Use internal storage and remove permissions for external storage

Someone raised the same concern some time back, so to tackle this and while supporting the older version, I added this to keep up with the latest guidelines. https://github.com/afreakyelf/Pdf-Viewer/blob/a2f11aa01fbfa4bdfaee5c7789c6504acb6c519f/pdfViewer/src/main/AndroidManifest.xml#L4-L5

Use internal storage and remove permissions for external storage

I believe its covered based on Android versions. https://github.com/afreakyelf/Pdf-Viewer/blob/a2f11aa01fbfa4bdfaee5c7789c6504acb6c519f/pdfViewer/src/main/java/com/rajat/pdfviewer/PdfViewerActivity.kt#L427-L447

Use internal storage and remove permissions for external storage

Closing this now as I haven't heard back. Please reopen if issue still persists.

Fix the bug of zooming when double tabbing & add animation

Hi, Can you please resolve conflicts? I will merge it over weekend.

Fix the bug of zooming when double tabbing & add animation

Hey, I appreciate your contribution, I took some references from your changes and improved the zoom in/out behaviour in my latest release. Thank you! If you think that it can...