Pdf-Viewer icon indicating copy to clipboard operation
Pdf-Viewer copied to clipboard
verified publisher icon afreakyelf

Fix the bug of zooming when double tabbing & add animation

Open aizpy opened this issue 1 year ago • 1 comments

  • Fix the issue of incorrect zoom-in position point when double tabbing
  • Introduce animation when double tab to zoom in and out.

https://github.com/user-attachments/assets/ae6f6e27-4f72-4a06-82c6-22848aea1bed

aizpy avatar Oct 12 '24 08:10 aizpy

@afreakyelf Please complete the code review and merge it in as soon as possible if it's okay. Based on the existing changes on the commit, I've also fixed the issue with finger dragging not following the hand when zooming in. See the demo below:

https://github.com/user-attachments/assets/2bf1f6e7-c092-41b9-8f94-f50aae774e14

The existing code needs to be reviewed and approved as soon as possible if the latest fixes are to be merged in as well.

aizpy avatar Oct 15 '24 08:10 aizpy

@afreakyelf this PR is helpful and fix actual bug, tagging to heads up

wiryadev avatar Nov 27 '24 13:11 wiryadev

Hi, Can you please resolve conflicts? I will merge it over weekend.

afreakyelf avatar Jan 18 '25 06:01 afreakyelf

Hey, I appreciate your contribution, I took some references from your changes and improved the zoom in/out behaviour in my latest release. Thank you!

If you think that it can be improved further, please feel free to raise another PR.

afreakyelf avatar Apr 14 '25 03:04 afreakyelf