Thomas Kerin

Results 77 issues of Thomas Kerin

**Summary:** An incorrect encoding is used when sending 'type=tpt' from the App, which means the server does not recognize the request as TPT request, but instead, a self-to-self transfer. This...

Fixes #1717 - alternative to the other PR, this one just uses long to match the server - [x] Apply the `AndroidStyle.xml` style template to your code in Android Studio....

In the HTLC example https://github.com/bitcoin/bips/blob/master/bip-0114.mediawiki#hashed-time-lock-contract I think there DROP is required after the CSV / CLTV opcodes There was branch by the same author @jl2012 to make CSV/CLTV actually pop...

Proposed BIP modification
Pending acceptance

This PR adds SignTxWitness which handles signing normal outputs + any that use segwit. It will return a signature script and witness structure after signing whatever it can and merging...

enhancement

At least trezor and electrum support [SLIP132 base58 prefixes](https://github.com/satoshilabs/slips/blob/master/slip-0132.md) for extended keys, which indicate the script type to be derived. I think it could be worth adding a flags parameter...

I've been reviewing for common libraries that may not yet have segwit address support. I haven't seen anyone work on it yet, please add this soon! https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki

Used to also allow hex, but makes no sense when we can just require a Buffer..

this has caused problems on occasion, especially if people are using older bitcoin-php versions.. maybe there's no point to using phpecc now that it's GMP only.

Revises schnorrsig implementation to be in line with secp256k1 upstream as of upstream commit efad3506a8937162e8010f5839fdf3771dfcf516 Adds extrakeys module