Thomas Kerin

Results 77 issues of Thomas Kerin

... or `\Base32\DecodeException` I found this test suite, the negative cases down the bottom are engineered to detect implementation errors we should add Base32 hex: https://opensource.apple.com/source/tcl/tcl-87/tcl_ext/tcllib/tcllib/modules/base32/base32hex.testsuite.auto.html Base32: https://opensource.apple.com/source/tcl/tcl-87/tcl_ext/tcllib/tcllib/modules/base32/base32.testsuite.auto.html On the...

Linking relevant issues and PR's here and any notes - [x] Composer 2 support - [x] Bump murmurhash3 - [ ] Bump mdanter/ecc https://github.com/Bit-Wasp/bitcoin-php/pull/877 - [x] Bump phpunit to test...

Dependency changes: murmurhash: ^2.0 phpunit: ^9.0 Test fixes: - Fixes up declaration of `setUp` which changed with PHPUnit versions - Adopt new usage for `expectException` - `assertInternalType` deprecated

This PR removes the Network implementations of dash, doge, litecoin, viacoin, and zcash. We added the NetworkInterface early on so people could 'bring their own' implementations when using the project,...

bc-break

bitwasp/bitcoin-bloom-filter https://github.com/Bit-Wasp/bitcoin-php-bloom-filter A dependency required for this doesn't support PHP8 yet, so I'd rather move it out of the core library. I've never heard of anyone actually using this. BC...

Not for merge yet, but started working on a phpecc-backed implementation of the schnorr signature implementation a while back. Opening the PR so I don't forget about it

Having the raw transaction (non-signed), how can I sign it using bitcoin-php version 1.0? _Originally posted by @Gwinest in https://github.com/Bit-Wasp/bitcoin-php/issues/166#issuecomment-588584875_

Fixes #805, and also checked every other usage of get_resource_type for same. Added tests covering these cases as well.

This PR removes the Collection classes, whose only usage is by ScriptWitness. This way the ScriptWitness class is a little easier to follow

bc-break