Andrea Fercia

Results 255 comments of Andrea Fercia

Some (most?) of the jsx-a11y rules can take a list of Components to check, see for example: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/label-has-associated-control.md We should check if that works with Styled Components too. However, Configuring...

Switching the dir="rtl" attribute is added in #685 To properly render in RTL, what is left here is: - the language used for all the text in the components should...

Also, not sure how the text passed via the default prop can be translatable: `descriptionEditorFieldPlaceholder: "Modify your meta description by editing it right here"`

For the `aria-describedby` still rendered even when there's no placeholder, see https://github.com/facebook/draft-js/issues/1739 and https://github.com/facebook/draft-js/pull/1741 still pending feedback from April 25, 2018.

Worth noting there's also a warning `Warning: Failed prop type: Invalid prop `ariaLabelledBy` of type `number` supplied to `ReplacementVariableEditorStandalone`, expected `string`.`

Looking a bit into this, it's a mystery to me. See screenshot below: there are two arrows displayed but the BaseUrl element has no `:before` pseudo element... so where that...

Hm.. I think it happens because Safari doesn't like too many re-renderings with CSS generated elements. To reproduce, try this: - click on the title - then hover a few...

@IreneStr I still can reproduce but only on the standalone version. Safari 11.1 on `feature/react-snippet-editor`.

Note: happens also on the new meta box.

Also, from #692 Noticed while working on #691 Code in SynonymsInput could be polished a bit, e.g. seems to me there's no need to explicitly check for non-null { explanationText...