Andrea Fercia

Results 255 comments of Andrea Fercia

> @afercia Looks like one order CSS was missed in this PR. The linting test is broken on trunk. Thanks for fixing it in https://github.com/WordPress/gutenberg/pull/61649. I think that `order` was...

Potential options to evaluate: - Specifically to the Settings and List view panels: do these panels really need a Close button? There's already a toggle button to open and close...

Cc @andrewfleming @alexstine @joedolson @WordPress/gutenberg-design In https://github.com/WordPress/gutenberg/issues/58940 / https://github.com/WordPress/gutenberg/pull/58942 a decisionw as made to not not introeuce a temporary, partial, fix for this issue and rather fix the broader issue...

> I'm not following; there are close buttons for the Inspector and List Views. As I mentioned in https://github.com/WordPress/gutenberg/pull/58942#issuecomment-1943403214 the 'inspector', also known as Settings panel, didn't use Tabs. It...

@alexstine I'm not sure I agree. While there are certainly more important issues, this ons is important as well. You may not know that https://github.com/WordPress/gutenberg/pull/61421 just added a new Close...

@ciampo @jeryj Sorry but Im not sure I understand how sovlign an issue by creating another issue is okay. The mismatch between visual roder and DOM order is an explicit...

Fair enough. Then I don't have more objections _as long as there is a clear established plan_ to fix the ARIA tabs pattern. As I see it, the only way...

Can't be done with just CSS because when tabbing backwards (Shift+Tab) there's no CSS selector that allows to target an ancestor of the focused row actions links.

> This problem does not seem to occur in WP6.5. Right. As also reported on https://github.com/WordPress/gutenberg/issues/61566 this appears to be a regression.

Cover blocks (and group blocks, and possibly other blocks) can already contain links: When a ["block-level link"](http://html5doctor.com/block-level-links-in-html-5/) is added to wrap the block, there shouldn't be other links within the...