Andrea Fercia

Stumbled upon this again while testing this WP core change: https://core.trac.wordpress.org/changeset/45925 One more non-functional UI in this page is the "Upload Image" button for Facebook and Twitter. To reproduce: -...

@Djennez see last comment 🙂 > I do realize the recommended setting is to enable "Redirect attachment URLs to the attachment itself?" (thus the metabox is not displayed). However, when...

@jeryj Thanks for this PR. Quickly tested and it looks like a good first step. Some considerations: The most important point is that arrows navigation wouldn't work well for Windows...

> Another hackier but potential solution might be to make the a role="button" and the button a role="none". Is this an especially bad idea or could it work here? Technically,...

To my understanding, by moving the props from the `li` to the `button`, also some of the styles are moved. This impacts the border radius of the button and the...

@jeryj thanks for your feedback. I have no strong opinions on whether to consider the social icons in the editor 'blocks' or 'buttons', the most important thing is that there...

@jeryj @getdave thanks for working on this. What's left here to get this merged? I'd love to fix also https://github.com/WordPress/gutenberg/issues/64972 but it would be good to merge this first. Thanks.

To my understanding, the markup on the front end doesn't change and that's great. In the editor, it does change and testing with Safari and VoiceOver, there may be a...

Couple thoughts: 1 One option could be removing `tabIndex` from the blockProps. This way the `LI`, which is the actual inner block, wouldn't be focusable any longer and focus would...

@jeryj thanks for the ping. Keyboard interaction is way better now, thank you! > I added the role=button as an override, and the semantics seem much better. Genuine question, I...