afdesk
afdesk
@LaibaBareera could you pls take a look too when you have time?
@jbenzel thanks! could you sign `license/cla`?
> Is this documented somewhere? If not, we should as it's a limitation today which may impact users. sure, I've added the next block here https://aquasecurity.github.io/trivy-operator/latest/docs/vulnerability-scanning/private-registries/
@simar7 I finally re-tested this PR and it's ready for your review.
@simar7 rebased the main branch and tested on Minikube
@simar7 could you pls take another look? thanks
@simar7 could you please prioritize this PR? The key change here is the removal of duplicate logic shared between the server and standalone modes. This will simplify maintenance, reduce the...
> I'll take a look at once I'm back. So we could aim it for the November end release. @simar7 sure! have a good vacation!
> @afdesk could you rebase this PR? done
@simar7 I remember you have a meticulous attitude toward testing, and I was thinking about how to add tests here. A simple table-driven test for `createEnvAndVolumeForGcr` doesn’t make much sense...