afdesk
afdesk
> > I'm unsure about logs. maybe it's a bit confusing for people. > cluster scanning can have many resources, and logging each individual resource scan is too much IMO....
@itaysk @knqyf263 could you take a look at this PR again? thanks!
@itaysk I finally clarify the reason of #7684 - the race condition appears between a few misconfig scanners, so this PR should resolve it too.
> lgtm, but I'll wait for @knqyf263 to take a look as well. @simar7 thanks for your review!!
> LGTM @knqyf263 thanks for your review. when tests are completed, I'll add this PR to merge queue, ok?
Hi @smtan-gl thanks for the contribution! it's really nice and important. I left some comments about this PR. also I took a look at #5889 it seems we have to...
> @afdesk any chance you might have context on this [question](https://github.com/aquasecurity/trivy/issues/5889#issuecomment-2330536466)? If I understand correctly there is an option to create an image with several tags, so it should be...
> @afdesk I've updated the PR, could you have another look please 😄 sure, thanks! I'll take a look
@smtan-gl could you sign CLA for a while? thanks!
it's a BREAKING change, so we have to create a new discussion about it. like here: https://github.com/aquasecurity/trivy/discussions/7010 we'll do it after the PR is merged. just to remember about it