afdesk
afdesk
> > @keliansb thanks for your contribution! I left some notes, WDYT? > > @afdesk I did the same configuration as the one already available in the [trivy-operator](https://github.com/aquasecurity/trivy-operator/blob/10390b5864399c3dbe2fa2f0b5f1a9bdf8cd1167/deploy/helm/values.yaml#L420) Helm chart....
@ktsakalozos thanks for the contribution! could you fix the linter tests?
fix: Correct test cases and audit commands for rh-1.8, cis-1.11, gke-1.8.0, and eks-1.7.0 benchmarks
@amitk1sharma thanks a lot for your efforts! I left some comments, could you pls clarify it? thank you for the PR!!
fix: Correct test cases and audit commands for rh-1.8, cis-1.11, gke-1.8.0, and eks-1.7.0 benchmarks
@mozillazg @LaibaBareera Could you pls take a look at this great job too?
@simar7 I left small comments, but it doesn't matter and up to you. actually I can't run Trivy-operator with this change: ```sh $ kind delete cluster && kind create cluster...
> can you share what led you to increasing the limits? @itaysk actually I always get `oomkilled` with the current settings on default KinD instances. so I'd like to increase...
@guipal Thank you for your interest! This particular issue originates directly from Trivy’s design. Unfortunately, there’s no well-established solution for it at the moment. If you have any ideas or...
Hi @guipal thanks for the report which version of trivy-operator do you use? there was merged a fix for trivy config file - #2713, and it should work in the...
> Can we add a test for this? A special case to handle in that test would be if `ttl` is set, it should respect that. done https://github.com/aquasecurity/trivy-operator/pull/2788/commits/b60f12f53ca9275e6e7536b3d4f24f497ee5e53f
@jbenzel thanks for your contribution! it's really nice!