Drew comments

Results 33 comments of


                                            Drew

breaking: use parseArgs from Node 18.3+ instead of sade/mri

@benmccann @jasonlyu123 let me know if you had something else in mind, happy to address any feedback.

breaking: use parseArgs from Node 18.3+ instead of sade/mri

@dummdidumm any thoughts on this one now? worth keeping/merging, or any rework or reconsideration you'd like here?

Unable to exclude directories from being watched with --tsconfig

EDIT: I misread the original message, my bad

Unable to exclude directories from being watched with --tsconfig

EDIT: I misread the original message, my bad

Unable to exclude directories from being watched with --tsconfig

My issue is with git worktrees, since we don't respect my TSConfig excludes I get EMFILE issues. Placing the worktrees above my repo root bricks AI assistants with security issues.

Unable to exclude directories from being watched with --tsconfig

I created a pretty simple repro: https://github.com/aewing/svelte-check-emfile-repro

Unable to exclude directories from being watched with --tsconfig

I just saw in your initial response you said we SHOULD use tsconfig include/exclude and I totally misread that the first time. Forgive me for that waste of time.

Unable to exclude directories from being watched with --tsconfig

I actually have a branch I prepared to respect the tsconfig settings I had prepared before leaving on vacation (I just got back), I will open an MR shortly.

Unable to exclude directories from being watched with --tsconfig

https://github.com/sveltejs/language-tools/pull/2807

[perf]: only create objects for completion items for svelte syntax once

I don't see any reason why we would need to do this dynamically, so this change is moving in a sensible direction. Not much gained from the change though. Plus...