language-tools icon indicating copy to clipboard operation
language-tools copied to clipboard

breaking: use parseArgs from Node 18.3+ instead of sade/mri

Open aewing opened this issue 5 months ago • 2 comments

  • Replace sade dependency with Node.js built-in parseArgs from node:util
  • Update engines requirement to Node.js >= 18.3.0 (when parseArgs was added)
  • Remove sade and @types/sade dependencies
  • Implement custom help and version handling to match original behavior
  • Add proper TypeScript types for parseArgs options

Resolves #2521

aewing avatar Aug 06 '25 23:08 aewing

@benmccann @jasonlyu123 let me know if you had something else in mind, happy to address any feedback.

aewing avatar Aug 06 '25 23:08 aewing

Looks good, but we should only merge this once we cut a new svelte-check release. Putting it into draft mode to prevent accidental merges. Thank you!

dummdidumm avatar Aug 14 '25 08:08 dummdidumm

⚠️ No Changeset found

Latest commit: 37a0a132e7f26b5e3e96e08a7a201ebd630436b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 19 '25 22:12 changeset-bot[bot]

@dummdidumm any thoughts on this one now? worth keeping/merging, or any rework or reconsideration you'd like here?

aewing avatar Dec 19 '25 22:12 aewing