Drew
Drew
Continuing the work done in https://github.com/sveltejs/language-tools/pull/2711 Most of the changes come from the conversion of snapshots to vitest snapshots. I tooled around with trying to get svelte 4 and svelte...
> I don't think merging every expected JSON snapshot into one giant file is a good idea. Ok, I can organize these into files that (mostly) align with the files...
> > The test timeout customisation shouldn't be removed either. > > Will fix this as well and take another pass on unnecessary changes that slipped through. I wasn't able...
> Thank you for continuing this effort! As for the snapshot changes, could you just revert to our custom setup for that part? I believe that setup is independent of...
> Thank you for continuing this effort! As for the snapshot changes, could you just revert to our custom setup for that part? I believe that setup is independent of...
Very sorry about the noise around CI on this one. I made a bit of a mess writing scripts to help me test and generate for svelte 4 vs svelte...
> Thank you for continuing this effort! As for the snapshot changes, could you just revert to our custom setup for that part? I believe that setup is independent of...
I have a bit more time to contribute over the holidays so I will be dusting this off and figuring out where the "expected_" changes were coming in, updating tests...
## Additional Context: svelte-check Integration Issue This limitation is particularly problematic when using TypeScript validation tools like svelte-check. The issue: 1. **svelte-check runs from main repository** and detects changes in...
## Technical Analysis & Root Cause I've reverse-engineered the cd protection implementation from the compiled CLI and identified the exact root cause and solution. ### Code Location & Implementation The...