Martin Aeschlimann

Fix URI creation from path

1

In 1.26 we discovered that several extensions call the 'vscode.openFolder' command with invalid file URIs: ``` `133,49: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(workingFolder));` `133,49: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(workingFolder));` `221,55: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(workingFolder));` ``` When creating a...

Range format should not make changes outside range

semantic highlighting no longer works for js/jsx files

1

Hi. As far as I know. typescript's built-in semantic highlighting doesn't work with js files. https://github.com/microsoft/TypeScript/blob/b1571fcb71501d16f21173979365d4c4d53a11cb/src/services/services.ts#L1888 I checked with the insider version of vscode. Semantic highlight no longer show up...

From https://github.com/microsoft/vscode/issues/97551 - VSCode Version: 1.45 - OS Version: Darwin x64 18.7.0 Steps to Reproduce: 1. create a typescript file 2. paste in this code: ```ts type Foo = {...

Reproduced with ``` const x = { xy: function () { this.id = 42; } } ``` The appearance of a `this` makes typescript think this is a class. 

Inconsistent token type when interface require optional properties

1

See https://github.com/microsoft/vscode/issues/95867 Reproduce recording:  Source: ``` import * as React from 'react' type SomeProps = { a: number } interface A { (props: P, context?: any): React.ReactElement; } interface...