Martin Aeschlimann

Results 100 comments of Martin Aeschlimann

Our converter removes some properties and adds some information. So don't use what's in VSCode as starting point. Better take the original [rust.cson](https://github.com/zargony/atom-language-rust/blob/master/grammars/rust.cson) and use the `cson-parser` node module to...

+1 for improving our benchmark. But I would suggest to add a new test instead of replacing the existing one. Also I would suggest avoiding randomized inputs but use real-world...

Moving the mapping system to the JS side sounds like a good idea. Encoding is already on the JS side, so why not remember the mapping and remember it in...

The Monaco HTML support doesn't include any validation and there are currently no plans to work on it. Contributions are welcome. The code base is at https://github.com/Microsoft/vscode-html-languageservice.

It just hasn't gotten any priority yet and surprisingly there haven't been many requests for it. My guess this has to do that there are plenty of good validators out...

I see that there are null checks since https://github.com/Microsoft/monaco-editor/commit/4f03f6c4bf64e7cb997855aab24c4db19a142923 That should be in builds >= 0.31. What version are you on?

I checked the playground and I see the null checks: ![image](https://user-images.githubusercontent.com/6461412/157821195-83f1918b-606c-42bd-a10f-cd50fe4905b7.png)

The go grammar does not seem to tokenize that correctly ![image](https://user-images.githubusercontent.com/6461412/186876737-35a18640-22ec-430f-923b-5389045a80b2.png) ``` type userData struct { name string id int } ```

I created https://github.com/jeff-hykin/better-go-syntax/issues/37