Adam Meehan
Adam Meehan
You're right, I hadn't thought of that. Then option 3 seems like the way forward. I don't like this idea of putting in work arounds for some other badly behaving...
Can you tell me if just moving the remotipart gem declaration in your Gemfile above wicked_pdf fixes this? On 26 Mar 2019, 12:27 PM +1100, David Jones , wrote: >...
I think I would probably invert the naming logic to something like `enable_render_overrides = true` and `enable_asset_helpers = true`. Also rather than creating parallel gem config, I would do this...
To add this config and extra complexity now seems more problematic than just moving to the Renderer solution which solves the render method problem as Rails intended and we can...
Ok I understand. The render method is the public API so a change to that would be a semver-like break. You have the experience with the user community so I...
Split out the PdfHelper into separate modules to explicit including or prepending depending on prepend support. Using the Renderer class makes this much cleaner. I think this should help fix...
The build is erroring and I don't know what to do about it. Gave it a kick. See error message https://travis-ci.org/mileszs/wicked_pdf/jobs/509342770
@unixmonkey I think that is a great plan. I'll let you get back to getting a stable release out. I'd be very happy to help get a major release out....
Sounds Good. My focus was to initially clean up the code and removing it from base Rails classes as much as possible. This would also include some work on extracting...
I have the same problem. For projects without a .rvmrc, PeepOpen will read the list of files. If the .rvmrc file is present, then it gets stuck at 'Reading files...'...