Adam Meehan

Results 36 comments of Adam Meehan

In principal I can see this would make things more consistent. The problem is it interferes with normal typecasting of strings to integers which can be passed to a write...

No I haven't got to it yet. This is probably caused by not requiring the specific ActiveSupport component that defines the classify method. Feel free to have a go at...

Thanks. Annoyingly he has not forked the project on github, but copied the source and made a new repo. Oh well, I just do it myself soon.

Thanks. I will take a look at it shortly to address the issues.

That require actually seems unnecessary as the gem/plugin should be loaded already after the environment loads. So I am not sure why this can't work without requiring ar_mailer at all.

Thanks but there was too much in this PR and it does not conform to the convention of a major version per ActiveRecord major version, so pushed necessary changes in...

yes that should be fine to add to the initializer

Thanks this has been implemented in other commits.