Adriel Perkins

Results 24 comments of Adriel Perkins

@crobert-1 - ready for another pass. Appreciate the review. For some reason the diff on the review tab is cached for me from GitHub. I resolved a bunch of conversations...

The failed links check is complaining about me linking to the file in `main` which hasn't been merged yet, so doesn't exist. Would it be better to link to the...

> [](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/9522512/196414933/32812/#/?version=2) [](https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/9522512/196414933/32812/#/?version=2) > > * ✅ login: adrielp / name: Adriel Perkins ([c82c97b](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/c82c97b87e7f9368e5205724c0ab9009fa4f9ddf), [f2db263](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f2db26388310f25d7dbcf2e6e2ecfe73e4da594e), [8c24669](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/8c2466932a3a6505a61d5b3d327f4e112442c8c1), [a312f79](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/a312f7928f939338fb0da254ca044e34728f9be7), [eb6ab5e](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/eb6ab5ecd5374717e0450b2c84748c5ac1e91215), [dbe9865](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/dbe98657431b058d1a6c87b3e3cc1bad4c5099dd), [a4cce65](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/a4cce659c7fc1bd08453a70ba2b694ebacef38b3), [ae25cdb](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/ae25cdbac72223066f523a4809430544a4d982fc), [b906a06](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/b906a06f590c69f79e4fb7994bce0d13d4f3b44f), [d8bf63d](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/d8bf63d2ac58d1f2e2e7856a94d6bf980ded8b06), [04aee28](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/04aee2851832995c738fcc25fc103562bbe26e26), [f0370b5](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/f0370b51fc6f2cf4ba930e8ce9541ade24682a66), [64f3884](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/64f388473677ba5301b06c4c4b92a78ca3f9b3fe), [b4b579b](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/b4b579b6a5c57e181a34b0c1e9dffe6f2a078f5a), [23fae24](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/23fae24a72e953dbc4372e17b9bdb40dd1d0e23c), [263971b](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/263971b2939dc4b9d742c4e7e81ab540b4f3beae), [5db15e3](https://github.com/open-telemetry/opentelemetry-collector-contrib/commit/5db15e36eca78b4b2fa39d75b3564876e10276ae),...

@crobert-1 - made a couple small logging statement updates & fixed a bug with metric build record statements running from within goroutines (mutex lock) - just wanted to let you...

So was able to get multimod to work after some troubleshooting. There's still some issues though that have to be fixed. 1. pkg.go.dev doesn't detect the version because semantic release...

TODO: (can be done under a separate ticket) * update the create release workflow to have a better changelog, the fix made the changelog suck * perf improvements * propose...

cc. @blairdrummond @acramsay

Hey @LaurentMarchelli 👋🏼 That was intentional. We ignore the default branch because the purpose of the metrics is to see how quickly (and if at all) teams are practicing trunk...

Appreciate your feedback on that @LaurentMarchelli We tossed around the idea of not including trunk from the branch count metric. And to your point, while it's called a branch, it's...

@LaurentMarchelli - I apologize if I came off as arguing. I was just typing out loud my thoughts. 😅 Maybe this is functionality that could be feature flagged such that...