Adrian Moisey

Results 168 comments of Adrian Moisey

> We are seeing this too. We are using the kube-prometheus-stack with two replicas of Prometheus behind a clusterIP service. > > I tried pointing it at a single replica...

The common pattern here seems to be the prometheus storage. Do these errors only happen on startup, or do they go away after some time? I'm not too familiar with...

Overall I like this change, but I'm not confident in my knowledge of this part of the code to give a formal `lgtm`, I'd rather someone with a little more...

The code seems fine from my perspective, but I'm not confident enough in this area of the code base to lgtm, I'll leave that to someone more experienced

> Should we split out the lifecycle of the CRD from the VPA binaries? > > eg. > > * VPA CRD changes must always be backwards compatible (unless there...

> > Once we graduate In-Place updates to Beta > > Beta would still allow to _disable_ a featuregate, right? Or do we not want to offer this option, such...

**Proposal:** 1. We change the version numbers of the VPA to match that of Kubernetes (cc: https://github.com/kubernetes/autoscaler/issues/5759) 1. Note: In the linked issue Marco describes some negatives to this approach,...

> I agree that changing the VPA version numbers to match Kubernetes makes things easier. But jumping from VPA 1.4 to 1.33 feels a bit strange and might confuse people....