Adriane Boyd

Results 345 comments of Adriane Boyd

Ah, with `Optional[]` I do like the `Union` version better. Maybe `Union` everywhere would just be simpler/clearer? An additional change would be to add `python_version=">=3.6"` to the setup. We should...

There are python 3.9 wheels for v2.0.5 for x86_64 and this package is pretty straightforward to compile from source (only requires cython), so I'm not sure what might be going...

Ah, possibly you just need to upgrade `pip` and `setuptools`? Try that if you haven't.

Are you still running into issues related to this? We haven't had any other related reports and without any tests, I'm a little hesitant about the changes in #13.

I think it would be useful to have an end-to-end test including the scoring with a custom prefix. It's easy to miss a place where it's accidentally just using the...

Minor in the scheme of things, but I think you can skip tests at the module level instead of having lots of repeated method-level skipifs: https://docs.pytest.org/en/6.2.x/skipping.html#skip-all-test-functions-of-a-class-or-module A more general global...

I assume you're waiting on the spacy docs to decide how to add this to the README?

Thanks for the PR! We'll double-check the performance internally and if everything looks fine, we'll merge this in preparation for the v3.5.0 `es` models.