spacy-lookups-data icon indicating copy to clipboard operation
spacy-lookups-data copied to clipboard

Add rules for verbs like "espiar" and "actuar"

Open nimbusaeta opened this issue 3 years ago • 2 comments

Adds rules to the whole indicative present paradigm, addresses issue https://github.com/explosion/spaCy/issues/11269

nimbusaeta avatar Aug 09 '22 09:08 nimbusaeta

Thanks for the PR! We'll double-check the performance internally and if everything looks fine, we'll merge this in preparation for the v3.5.0 es models.

adrianeboyd avatar Aug 12 '22 08:08 adrianeboyd

Hi @nimbusaeta, thanks for your commit. I've also added the third-person plural present subjunctive forms. Could you please check you agree these are linguistically correct, and if you're happy with them I'll approve the PR.

richardpaulhudson avatar Sep 01 '22 06:09 richardpaulhudson

Hi @richardpaulhudson, sorry I missed that tense! They are totally correct.

nimbusaeta avatar Sep 07 '22 21:09 nimbusaeta

Thanks for the feedback!

adrianeboyd avatar Sep 08 '22 12:09 adrianeboyd