Adriane Boyd

Results 349 comments of Adriane Boyd

I was imagining something that could show a bit more about how to specify it as a dependency, so at least some option with more details like: ``` $ spacy...

I think providing just the wheel URL is fine and just providing the same URL as you would get from `spacy download` is also fine. The no-internet error is pretty...

Actually if the model is installed locally, it might make more sense to provide that version, or possibly to provide both?

I'll take another look. Can you update the PR description?

I think the functionality is looking good. Do we want to include the changes to the docs in this PR or a follow-up PR? There are at least these sections:...

I realize this is a draft, but some general concerns: * there are multiple components with thresholds, can this be implemented more generally? * I'd rather see the scoring code...

In general the situation is that you have a component that has: * some config setting that's a threshold that's used in `set_annotations` or the scorer * some score that's...

No, I think we need to rely on the user to provide a path to the threshold in the config and the scores key to optimize. In v4, I'm planning...

The component already has a registered scorer, so what I mean by "scores key" is the entry in the output of `Language.evaluate` that you want to optimize, like `cats_macro_f`. You...

I don't think beta makes sense as a `Scorer`-level setting but rather as an individual component scorer setting that would be set in the config, e.g.: ``` @registry.scorers("spacy.textcat_scorer.v1") def make_textcat_scorer(beta:...