Axel Donath

Results 231 comments of Axel Donath

@AtreyeeS This is a backwards incompatible change and it would be bad to introduce it between v1.0rc and v1.0, because it might change analysis results. I'll label the issue after...

The new `SpectrumDatasetMaker`has the option to compute background spectra from background models. Currently the functionality is tested, but un-documented and not used or shown in tutorials. @registerrier Should we add...

We could also add support for `RegionGeom` to the `RingBackgroundMaker`, should be easy to do...

@registerrier and @bkhelifi The maybe a Gammapy recipe is the good solution here? Showing how to use `pint` to compute the H test from Gammapy data?

In general I think we should not consider writing a single for loop as inconvenient for users, especially if they rely on the 2nd level API. I think this is...

There is one technical challenge here. If users have many datasets that don't fit in memory or are read lazily we run into memory issues here. The approach in this...

Thanks a lot @LauraOlivera, I fully agree this is important information to keep. I think there is already a very good place to store this kind of information: the `RegionGeom`...

The base of my proposal above was a `RegionArray` class, essentially and extension of the `Region` class in Astropy's `regions` package to support arrays of positions, region sizes etc. I...

> If I understand it right, one would need to create two specific RegionArray (sky and pixel) for each shape, right? Which I guess is not too extreme since we...

Just for reference here is a more efficient similar implementation, that I found on my hard disk: ```python3 from gammapy.catalog import SourceCatalog3FGL from astropy import units as u from scipy.sparse.csgraph...