Axel Donath

Results 234 comments of Axel Donath

@registerrier As a long term solution I probably also agree, however given the convention we have now, adding the energy dependence to the temporal model seems a bit clearer to...

What is the status here @AtreyeeS? Would you still like to add those for v1.0rc?

The `CountsStatistics` consistently convert to `np.asanyarray()` they don't preserve scalar values. This is maybe not the perfect behavior but it is consistent with in `gammapy.stats`.

@bkhelifi Is this ready to merged from your side?

Thanks @QRemy! This is also what confused me, because I have worked with signed tags in the past, where it is lower-case. This is an inconsistency in the `git` API,...

@bkhelifi I think there is a misunderstanding, which maybe needs to be clarified in the PIG as well. I think the author information (like name, ORCID and affiliation) should be...

@maxnoe Thanks a lot for taking the time and review! I responded to some of your inline comments to clarify a few things. I think the proposed policy is mostly...

@bkhelifi Any proposal where to put our copy of the DCO? Probably it is best to include it on our webpage?

@bkhelifi Can you please address the remaining open small comments? Then I think this PIG is ready to be accepted...Thanks!

This could be addressed as part of a `gammapy.maps` refactoring for v2.0.