Aditya Shrivastava

Results 8 comments of Aditya Shrivastava

Hi @terrytangyuan, I have made some changes and the bug seems to be fixed. I have added a comment in the issue #9281 with snapshots of the same. Can I...

Sure, I will do that. Can you tell me what unit tests I should be adding before sending a PR? I don't have much experience with TDD so I am...

Thanks for the help. I was able to make a PR #9874 but one of the checks seems to have timed out and got cancelled. How can I re-run the...

Thanks all the checks have passed now. I have marked the PR as "Ready for review".

Thanks. I would definitely try and contribute more. :smiley:

Hi @alexec, I am new to open source and would like to try and work on this issue. Can you assign it to me?

Update on the issue: I have been learning Go and Kubernetes and reviewing the documentation to better understand the project.

Hi @alexec, I have made the following changes: ![bug-fIx](https://user-images.githubusercontent.com/39914834/196519205-b87effa7-a3cc-432b-bb9c-0468f2aa055d.png) After running `make cli` I was able to submit an example workflow to get the expected P/R/C results: ![submit-workflow](https://user-images.githubusercontent.com/39914834/196520058-655df862-813d-4026-b310-de3eaf755512.png) ![prc-working](https://user-images.githubusercontent.com/39914834/196520250-2fa4148b-121c-4ef8-b5dc-b5e04396b249.png) Log...