argo-workflows icon indicating copy to clipboard operation
argo-workflows copied to clipboard

Does P/R/C reporting on argo list -o wide still work?

Open withnale opened this issue 3 years ago • 5 comments

Whenever I try running any of our workflows and I used

argo list -o wide  -A

NAMESPACE   NAME                                                         STATUS      AGE   DURATION   PRIORITY   P/R/C   PARAMETERS
dev         dev-abc-defghij-default-1659528000                           Running     4m    4m         0          0/0/0
dev         stable-another-job-def-g64cn                                 Succeeded   11d   7h         0          0/0/0

I've tried this with our job definitions and I've also tried this out of the box some of the workflows in argo-workflows/examples and I've yet to see a case where it works.

Summary

What happened/what you expected to happen?

The P/R/C column is populated based on the number of pending/running/completed steps of the workflow.

What version are you running?

We're running v3.2.9 but I've also tried it with v3.3.7

withnale avatar Aug 03 '22 12:08 withnale

This happen because of this line of code:

https://github.com/argoproj/argo-workflows/blob/f27475feb850dc43e07c3c5215cc9638947f0859/cmd/argo/commands/list.go#L48

It should be easy to add an option for wide.

alexec avatar Sep 05 '22 20:09 alexec

Hi @alexec, I am new to open source and would like to try and work on this issue. Can you assign it to me?

aditya-shrivastava avatar Sep 09 '22 11:09 aditya-shrivastava

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

stale[bot] avatar Oct 01 '22 06:10 stale[bot]

Update on the issue: I have been learning Go and Kubernetes and reviewing the documentation to better understand the project.

aditya-shrivastava avatar Oct 01 '22 06:10 aditya-shrivastava

Hi @alexec, I have made the following changes: bug-fIx

After running make cli I was able to submit an example workflow to get the expected P/R/C results: submit-workflow prc-working

Log of the example workflow: steps-logs

Kindly let me know if this fixes the issue or if I need to make more changes. Also, I would highly appreciate it if you could tell me what unit tests I should add for the above changes before making a pull request. :smiley:

aditya-shrivastava avatar Oct 18 '22 19:10 aditya-shrivastava