Andreas Bender
Andreas Bender
I think this is a more general issue: https://github.com/mlr-org/mlr3pipelines/issues/291
## Review checklist for @adibender ### Conflict of interest - [x] I confirm that I have read the [JOSS conflict of interest (COI) policy](https://github.com/openjournals/joss/blob/master/COI.md) and that: I have no COIs...
@majensen Hi, sorry. Yes, will finish the review until 12th of august.
I've left an issue regarding the Example Usage vignette here: https://github.com/nhejazi/haldensify/issues/37 Otherwise good to go from my side
Hi, @majensen I've left some additional optional comments. Up to @nhejazi Good to go from my side.
> That would be amazing Seconded! I've just spent ~15 minutes trying to understand how to use some learners in proba (since they moved to separate repos) and I was...
Yes, vlaidation of the censoring model is a problem. But we should allow it should be able to a) recreate results from literature b) use it for comparison when they...
The `Surv` object does allow factor variables for the event in order to indicate CR/Multi-state outcomes. So specifying the task should be possible. How this is passed to the individual...
> stupid question - what precisely is the "discrete survival" task for you? Is there a summary/description somewhere? You discretize the follow up into intervals, and create pseudo data with...
@RaphaelS1 Looks legit, however, - `n` should probably be increased. As you assume that baseline hazard is constant in each interval, 5 or 10 intervals might be to crude -...