Adarsh Sanjeev

icon location Bengaluru

Results 10 comments of Adarsh Sanjeev

Add manifest file for MSQ export

To see if the created export file is in the symlink format, I generated manifest files using Apache Spark with Delta Lake. The generated file is in a similar format...

add google as external storage for msq export

Thanks for the PR! I'll take a look at it shortly.

add google as external storage for msq export

Yes, the changes look good to me! Thanks for the PR!

Fixes a bug when running queries with a limit clause

> The finalShuffleSpec must also be set in the case of ingest queries. ~Ingest queries do not allow limit, unless the partitioning is ALL, so this case shouldn't happen.~ I...

Fixes a bug when running queries with a limit clause

I have refactored the code in the QueryKits and added additional tests to address the comments.

Make tempStorageDirectory configuration optional and rely on task dir instead

@cryptoe could you please take a look at the changes I made now to MSQDurableStorageModule?

Aggregate functions on string columns

Thanks for making the PR! I'll try to review this soon.

Fixed ClassCastException during Multi-Stage Queries on real-time segments

@nozjkoitop I think @LakshSingla's comment was to only make changes that affect MSQ, since the bug is seen only there. I think your changes might affect other queries as well.

Fixed ClassCastException during Multi-Stage Queries on real-time segments

Sure, I can take a look at this bug

Introduced `includeTrailerHeader` to enable `TrailerHeaders` in response

@vivek807 I was trying out this change. I was able to see this header only if I was directly hitting the broker. Hitting the router (that is, `localhost:8888` if you...