add google as external storage for msq export
Description
Support for exporting msq results to gcs bucket. This is essentially copying the logic of s3 export for gs, originally done by @adarshsanjeev in this PR - https://github.com/apache/druid/pull/15689
Release note
Support for exporting MSQ results to a GCS path.
Key changed/added classes in this PR
-
GoogleExportStorageProvider.java -
GoogleStorageConnectorModule.java
This PR has:
- [x] been self-reviewed.
- [ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [x] a release note entry in the PR description.
- [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in licenses.yaml
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
Thanks for the PR! I'll take a look at it shortly.
Some minor copyedit nits. The only absolutely must fix one is the incorrect cloud provider being listed in an intro sentence
thanks @317brian added your commits
@adarshsanjeev anything else ?
@adarshsanjeev yes tested on a cluster
@adarshsanjeev - If its looks good to you, can we merge this?
Yes, the changes look good to me! Thanks for the PR!