adams85

Results 45 comments of adams85

The fact you've ended up with such a use of `Node.Data` just confirms that this change would be desirable. I have an API like this in mind: ```csharp public abstract...

> I'm no performance guru, so I have little actual feeling about whether the memory issue is a big problem. But is there any reason that we couldn't just use...

> Funny thing is that this is very close to my very own solution. Check out the PR I've submitted. Hopefully, this will make use cases like yours easier to...

You have some nice improvements in the works! Variable scope validation in JS (if we're talking about the same thing) is a deep, dark rabbit hole in my experience though......

Though inheritance is not possible, we still have composition as an option: ``` public struct Token { public TokenType Type; // ... public object? ExtensionData; }` ``` Of course, this...

> I'm leaning towards having custom [TextSpan](https://github.com/sebastienros/parlot/blob/main/src/Parlot/TextSpan.cs) like Parlot has and then allowing span-based operations via it's Span property. Isn't `TextSpan` practically the same as [`ReadOnlyMemory`](https://github.com/dotnet/runtime/blob/v6.0.5/src/libraries/System.Private.CoreLib/src/System/ReadOnlyMemory.cs)? Though I don't know...

> What I remember from Memory, it brought quite the overhead, might have used it wrong too tough. I'm also not an expert on `(ReadOnly)Memory` but at first glance it...

In the light of work done recently we can consider this done, right?

> please keep refactoring to minimum when it comes to class related things May I proceed with https://github.com/sebastienros/esprima-dotnet/issues/264 or would I rather wait until this one is resolved?