esprima-dotnet icon indicating copy to clipboard operation
esprima-dotnet copied to clipboard

Published 20 hours ago • verified publisher icon sebastienros

Fix class-related parsing problems

Open lahma opened this issue 2 years ago • 6 comments

Assigning to myself as work started with https://github.com/sebastienros/esprima-dotnet/pull/248 , trying to get problems to zero.

lahma avatar Jun 08 '22 17:06 lahma

/cc @adams85 @Xicy please keep refactoring to minimum when it comes to class related things, small bug fixes and tweaks OK, I'll manage. Also you can raise ideas/tasks to be included in v3 milestone I've created.

lahma avatar Jun 08 '22 17:06 lahma

And of course @jogibear9988 , see above, sorry I missed you - you three have been most active recently - and help is much appreciated! Refer to family and friends to get even more traction 😉

lahma avatar Jun 08 '22 17:06 lahma

And of course @jogibear9988 , see above, sorry I missed you - you three have been most active recently - and help is much appreciated! Refer to family and friends to get even more traction 😉

Your welcome, I learn too much thing from yours. I had not time for these week also I did not looks @adams85 and @jogibear9988 mentions, sorry for that.

/cc @adams85 @Xicy please keep refactoring to minimum when it comes to class related things, small bug fixes and tweaks OK, I'll manage. Also you can raise ideas/tasks to be included in v3 milestone I've created.

If I have enough time, I will try to implement Span #22. If you want, I will wait for the future release.

Xicy avatar Jun 08 '22 18:06 Xicy

I've never looked what problem still exist... Only if someone mentioned some issues, I looked after them. :-)

I still have some pull request I need to look after: https://github.com/node-projects/esprima-next/issues/24

and also I need to look at all pull requests after #222, wich I need to add also to esprima-next

jogibear9988 avatar Jun 08 '22 20:06 jogibear9988

please keep refactoring to minimum when it comes to class related things

May I proceed with https://github.com/sebastienros/esprima-dotnet/issues/264 or would I rather wait until this one is resolved?

adams85 avatar Jun 09 '22 13:06 adams85

@adams85 please go ahead!

lahma avatar Jun 09 '22 13:06 lahma

should we close this? i think most works at the moment

jogibear9988 avatar Dec 28 '22 18:12 jogibear9988

I think we should keep this open just a little bit longer. Probably when allow-list.txt does not have class-related relaxations this should be quite complete 🙂

lahma avatar Dec 29 '22 16:12 lahma

I believe this is completed now, right?

adams85 avatar Feb 25 '23 19:02 adams85

Some validation still missing like hoisting scope names but this can be closed.

lahma avatar Feb 25 '23 19:02 lahma