Adam Johnson

Results 620 comments of Adam Johnson

I still intend to add this

Thank you for the PR, I finally found time to review and finish it off. You may be interested in reading the intermediate commits.

Adding skip syntax would be great. It needs to be added for all supported markup languages. I think the easiest is to support on/off comments, and then we can ignore...

Yeah, I can't really spot why the final block isn't being picked up. Could you minimize the file down to the smallest failing example? That would probably reveal the problem.

I think I just fixed the “rest of the file” bug in #347. But the docstring is still being left in a broken state, and that isn't something we can...

So SuperFences is an extension for Python Markdown? I feel like it’s ma bit niche to add support for at this time, and more importantly commit to maintaining. You’re free...

Yes, let's add the new parser, but leave the "check" function for now. I previously discussed a "check"/"dry run" feature in #197 and concluded that it's not worth it when...

Yes, this PR revealed no issues on 4.2. My follow-up, #438 , did fix some issues for Django 5.0.

Currently there are three test failures: ``` FAILED django_countries/tests/test_admin_filters.py::TestCountryFilter::test_choices - AssertionError: False != True FAILED django_countries/tests/test_fields.py::TestModelForm::test_translated_choices - AssertionError: 'Afghanistan' != 'Afganio' FAILED django_countries/tests/test_widgets.py::TestCountrySelectWidget::test_render - AssertionError: 0 != 1 : Found...

I think we can stop using `LazyTypedChoiceField` / `LazyTypedMultipleChoiceField` and all related classes on Django 5.0, since a callable for choices is treated lazily by Django. But unfortunately there’s a...