Adam Johnson comments

Results 349 comments of


Adam Johnson

Use os.exec rather than sys.exit(subprocess.call(...))

Oh interesting, good to know. Perhaps there could be a check to use `exec` on unix only?

Document Django's built-in JSONField

I have no idea

Add "current python" factor

Some of the isort changes here are due to the release of isort 5, and will be superceded by #16.

This may be somewhat redundant, since [IPython has the ability to run Black](https://ipython.readthedocs.io/en/stable/whatsnew/version8.html#auto-formatting-with-black-in-the-cli) on input lines during execution. It doesn't help with reformatting existing shell sessions but it covers creating...

Implicit namespace submodules not discovered

> Would it be acceptable to have to enable implicit package spidering with a config setting? For me, yes, but I fear it would only be discovered by a few....

Don't create the weak dicts for individual objects

Smart 🧠. You could drop the `>= 2` check in `should_prefetch` and just have a check that the `_peers` attr exists, to avoid repeating the magic number 2. Also add...

Don't create the weak dicts for individual objects

Good point

Added aws cfn-python-lint

+1 I think this should be at the top of tools, if they aren't to be maintained in alphabetical order, since it's an official AWS tool for checking templates.

Support using `pathlib.Path` object as input to `add_attachment`. (Part of Py3.4 stdlib.)

Reopening https://github.com/jsocol/django-ratelimit/issues/252 with reproducible steps

Thanks for making a reproducible report. Unlike #252 I see `VERSION = (3, 0, 1)` in `__init__.py`. But I do see a `models.py` and a `utils.py` file, which indeed do...