django-countries icon indicating copy to clipboard operation
django-countries copied to clipboard

Test on Django 4.2

Open adamchainz opened this issue 2 years ago • 4 comments

Update the test matrix to test with Django 4.2, the new LTS release. No changes were needed in the package for compatibility.

I wasn't quite sure whether we'd also move the "previous" and "legacy" pins. I would recommend supporting Django 3.2 through 4.2 for the time being, since 3.2 is still supported upstream until April 2024: https://www.djangoproject.com/download/#supported-versions

adamchainz avatar Apr 24 '23 15:04 adamchainz

I would recommend supporting Django 3.2 through 4.2 for the time being, since 3.2 is still supported upstream until April 2024

Makes sense to me.

I'm not a maintainer, but a reasonable strategy might be to change the"previous" to 4.1, and leave "legacy" as 3.2. That would mean 4.0 is technically not tested, but if it works on 3.2, 4.1 and 4.2, it's probably fine on 4.0.

Also, 4.0 is out of extended support upstream, not sure if django-countries wants to stop advertising support for it and remove the trove classifier.

Just my 2 cents as a user of the lib.

browniebroke avatar May 04 '23 11:05 browniebroke

Any chance this could be released? It's blocking our upgrade to Django 4.2 Thanks.

chaudhary-kaushal avatar Jan 24 '24 06:01 chaudhary-kaushal

It's blocking our upgrade to Django 4.2

It shouldn't be a blocker: there is no actual code being fixed here, it's just to cover testing, and everything passes. Are you getting a specific error? If so, it might be more productive to report it in a separate issue.

browniebroke avatar Jan 24 '24 10:01 browniebroke

Yes, this PR revealed no issues on 4.2. My follow-up, #438 , did fix some issues for Django 5.0.

adamchainz avatar Jan 24 '24 10:01 adamchainz

@MarcoGlauser What about starting with this simple one :wink:

claudep avatar Mar 26 '24 16:03 claudep