Adam Johnson

Results 586 comments of Adam Johnson
trafficstars

> (No idea why 8cc2d71 is showing as before 3be615f) (GH's UI confusingly sorts by commit date rather than parentage, which can mean rebasing gets things all over the place)

As per comments on ticket: https://code.djangoproject.com/ticket/30746#comment:2 - we will not add Permissions-Policy to django core until it's not a draft. Not much seems to have changed on that front in...

Thank you, I"ve added to `MANIFEST.in`.

Ah I didn't read the logs enough, the [failure on master](https://github.com/encode/django-rest-framework/runs/7723994188?check_suite_focus=true) was due to the missing source map: ``` dist run-test: commands[0] | ./runtests.py --no-pkgroot --staticfiles Post-processing 'rest_framework/css/bootstrap-theme.min.css' failed! ......

You can also add source map files, even empty ones, to your project's static folder. Use the right file names: `rest_framework/static/rest_framework/css/bootstrap-theme.min.css.map` and `rest_framework/static/rest_framework/css/bootstrap.min.css.map`

> from cli calling ` heroku config:set DISABLE_COLLECTSTATIC=1 ` is also an option This is not a good idea as it will break static assets for most projects.

Yes, #8599 is where that is happening.

@hiAndrewQuinn Downgrading is probably the right approach there. Does the book not reccomend using a specific Django version from the start though? I know Will only advertises the book as...

Great, if you find time, could you make a PR to remove those lines, or to add the source map files to the repo?