Adam Johnson

Results 593 comments of Adam Johnson

I ran py-spy on the test suite and checked with speedscope, it seems `record_sql_queries` is most of the source of the overhead. (This screenshot doesn't show much information but I...

> (This screenshot doesn't show much information but I couldn't find any other to post without confidential info) Yes that's the flame graph for it. I can't show more sorry....

I'm afraid I don't have time to try this. I hope you take your own profiles from a representative application.

2c: perhaps a `TypeError` is a more appropriate exception class, since the error case is the decorator being applied to the wrong *type* of callable.

It looks like the type of `channel_capacity` is swapped for a list of tuples with `compile_capacities` in `channels_redis`: https://github.com/django/channels_redis/blob/0c27648b60a1918c867b96a5ad3f67ef58ccceda/channels_redis/core.py#L200 I guess we should fix the `BaseChannelLayer` definition to always store...

I'm predictably +1 on this 👍

Yes it could make sense it core. django-read-only still needs some work though, to be rewritten with a better technique: https://github.com/adamchainz/django-read-only/issues/20

Hi @kbhalerao I think you've found the problem. It's documented as supporting that, but the code doesn't. It needs a test, then refactoring to match that.

👍 We have a whole lot of feeds approved and merged into the aggregate feed - 451 at current. I think we'd want to restrict to display sites that have...

HTTP/2 technically can work without encryption but all browsers only support HTTP/2 with TLS (see [wikipedia](https://en.wikipedia.org/wiki/HTTP/2#Encryption)). So it may be the case that the HTTP2 support in Daphne is limited...