Adam Johnson

Results 598 comments of Adam Johnson

Oh yeah, I disabled `assign-if-exp` altogether, I don't like `return x if y else z` generally, but the long lines did push me. Expression complexity is worth considering. For example:...

Slightly more robust than `sed`, I’ve come up with a workaround to apply the below patch with: ``` git apply --unsafe-paths /tmp/cfn-bootstrap.patch --directory /usr/local/lib/python3.10/dist-packages/cfnbootstrap/ ``` patch file: ```diff diff --git...

You can disable rules with the [Metadata section](https://github.com/awslabs/cfn-python-lint#metadata), [example in tests](https://github.com/awslabs/cfn-python-lint/blob/7eb6fd3ba1fdccf09326d89e73a22924f99de21d/test/fixtures/templates/good/core/config_parameters.yaml).

I think that's basically a bug and should be filed separately Also hint: you don't need quotes around all your Refs, i.e. `!Ref DBSecurityGroup` is equivalent to `!Ref 'DBSecurityGroup'`.

It looks like it, yes. The stubs are unfortunately not verified against Django's codebase at current, so we rely on spotting fixes from usage, like you've done 😊

3.71 isn't a real Mypy version, did you mean 0.971 maybe?

@JonG0uld can you make that Google sheet public? I’m seeing the “You need access” screen.

I recommend not distributing the tests. 99.99% of installs do not need them. Those who want them are normally redistributors, can who fetch the tarball from the repo. Last year...

> Anyways let me look into that, perhaps user agent header server side will be sufficient. Please don't try use the User-Agent header, it's only robust to do it client...