Adam Johnson

Results 600 comments of Adam Johnson

Yeah setting up a file is a good idea, it allows you to enable PR builds as well to check no change breaks the docs. Here's an example from one...

Unsure about making this the default. [Docs](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instancedata-data-retrieval.html): > The IPv6 address is only accessible on Instances built on the Nitro System. And: > The following instances are built on the...

I need more information. I've never used a docker container with bridge mode. There shouldn't be anything fundamentally different between curl and python... Can you try using netcat, or opening...

can you provide a way to recreate this? otherwise I can do no more.

If `requests` works, this package should work, as it's only a thin layer around requests - see the code: https://github.com/adamchainz/ec2-metadata/blob/70d1ecdae9a86acaeb8005d353e0cfc53ffdf628/src/ec2_metadata/__init__.py#L71-L77

Please consider this PR. `future` triggers a warning on Python 3.8: ``` /.../future/standard_library/__init__.py:65: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses...

FYI I built a faster alternative to freezegun called time-machine. See https://adamj.eu/tech/2020/06/03/introducing-time-machine/ .

Gonna continue on this tomorrow.

It also looks like commits weren't pushed to GitHub - the release was done 13 sep but the last commit currently visible on `master` is 16efa94e96565c5cd2b29f3e726bc961b275f832, from 27 aug. Given...

If the 80 chars includes the `if var := `, then yeah something like that would make sense.