Oleksandr Kulkov
Oleksandr Kulkov
Hi Giulio! I was on vacation for last two weeks, but am now back and ready to work further on this. That is, if further work is required 🙂 I...
I added a new commit that merges upstream changes from Harun's PR. Should be ready for merge now 🙂 Regarding SSHash-v2 paper: Sure, I would be happy to contribute! Please...
Hi @jermp ! I noticed that there were some new commits to the master branch on your side, which created a new marge conflict for this PR. I can update...
Hi @jermp , thanks for the update! I've merged your changes into the PR, and also briefly re-run check and bench on `se.ust.k63.fa.gz` to make sure I didn't break something...
For the largest kmer length, it's hard to tell because we didn't really try anything beyong `k=127` yet. For me, `k=127` seemed reasonably fast, but I don't know if it...
Hi @jermp any updates on merging this (and also on communications re: preparing a new paper)? 👀 I added two minor pull requests from Harun to our fork, they are...
Thanks for the comment! Wouldn't it be slower on practice though? I imagine `i % pr[j]` operation would be much costlier than `pr[j] == lp[i]`. I guess we could still...
$\log k$ factor is pretty standard for `std::map`. I guess we can change it to `std::map` instead of just "map" to be explicit here. Would you like to make a...
Thanks!
Hi, thanks for the pull request! But I'm a bit confused, so you mean that the current implementation is incorrect? Is it possible for you to also add a fix...