Oleksandr Kulkov
Oleksandr Kulkov
Hi @bbowles1! Does the issue still occur to you? I tried to do the following: ```console sudo docker pull ghcr.io/ratschlab/metagraph:latest sudo docker run -it --entrypoint /bin/bash ghcr.io/ratschlab/metagraph:latest ``` Then, in...
@hmusta I tried using Metagraph as an external project, and besides problems with includes (that are at least resolved by this commit), I also get a bunch of linking errors:...
This is true, but currently Metagraph doesn't even install it in the install dir: ```sh $ ls install/lib/ cmake libjsoncpp.a libmetagraph-core.a libz.a pkgconfig ``` Do we want to also put...
Isn't it already linked statically the way it is written now? I'm not sure what needs to be updated to ensure it.
Will continue in #565
Thank you very much for the contribution! And sorry that it had to take a while to do the review :slightly_smiling_face:
It's generally considered a good practice to not fail on corner cases. Small inputs are often used for unit testing, or even manual tests, when you're more concerned with logical...
Hi @jermp, thanks for the update! But `sshash` exclusively relies on external memory for minimizers [here](https://github.com/jermp/sshash/blob/6904074c95bdee45699b3eab9ed7e660ab3b7fe8/include/minimizers.hpp#L32), so we still require some workarounds for this on our side.
Hi! It's actually mentioned in the article [here](https://cp-algorithms.com/data_structures/fenwick.html#one-based-indexing-approach). But I generally agree that the code with 0-based Fenwick is pretty ugly + makes our life harder e.g. when we want...
@UtsavKashyap1710 thanks for the code, but issues section is only for text discussions, actual contribuitions should be done via pull requests.