Oleksandr Kulkov

Results 210 comments of Oleksandr Kulkov

Thanks for the pull request! I have few concerns here: 1. At the moment the implementation is just dumped in the middle of the paragraph without any further explanation. The...

@A-stick-bug hi, do you plan any further work on this pull request?

Thanks for the pull request! Do you think you can also provide some implementation and benchmarks for this method? I'd really like to know how much it improves on practice....

I don't write ternary search that often... Perhaps, using `lm = l + (r - l) / 2.1` and `rm = r - (r - l) / 2.1` is better...

@SYury hi, do you have any updates on this? Do you plan to move forward with benchmarks?

Another important point is, I would really appreciate it if the change also included the implementation for this approach.

I think there is a significant practical benefit in terms of constant term optimization if function computation is costly. Especially in the case of nested search, the constants multiply which...

@SYury hi, do you plan any further work on this?

Sure, feel free to open a pull request if you have some appropriate changes.