Ada Alakbarova
Ada Alakbarova
I think this can be closed now?
I think #199 closes this?
hi, it seems like you forgot to close this issue
Oh god sorry I totally misread this. So: 1. I created a small config (literally just the rust-analyzer setup), and it does indeed fail to find the workspace when I...
"Valid Rust code" refers to syntactic validity -- this is in contrast to [`HasPlaceholders`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_lint_defs/enum.Applicability.html#variant.HasPlaceholders), which, well, has placeholders in the suggestion, so that, if you were to paste in the...
> it increases the minimum rust version to match the latest `bincode`'s minimum Rust version maybe it would make sense to choose the latest MSRV-compatible version of `bincode` instead?
This could arguably be 3 separate lints: - turn `.append(&mut v)` into `.extend(v)` (has a lint request already: #12277) - turn `.extend(vec)` into `extend(arr)` (would be an enhancement on `useless_vec`)...
> since doing this on a string also would not work I think it would work, you'd just need to suggest `as_str`/`as_str_mut` instead. But this could be left as a...