log icon indicating copy to clipboard operation
log copied to clipboard

Add `bincode` feature for encoding and decoding with bincode

Open ChocolateLoverRaj opened this issue 5 months ago • 3 comments

Similar to how there is a serde feature

I implemented this here, but I'm not making a PR because I doubt it will get accepted (mostly cuz it increases the minimum rust version to match the latest bincode's minimum Rust version)

ChocolateLoverRaj avatar Jun 05 '25 17:06 ChocolateLoverRaj

it increases the minimum rust version to match the latest bincode's minimum Rust version

maybe it would make sense to choose the latest MSRV-compatible version of bincode instead?

ada4a avatar Jun 10 '25 13:06 ada4a

If we did that that would be bincode 1, which I think does not have its own encoding macros.

ChocolateLoverRaj avatar Jun 10 '25 14:06 ChocolateLoverRaj

Thanks for the suggestion! We currently support serde in log because it's a very common interchange library. I don't think we'd likely add direct support for bincode to log itself.

KodrAus avatar Jun 14 '25 18:06 KodrAus

Per the last comment I'm going to close this.

Thomasdezeeuw avatar Sep 06 '25 11:09 Thomasdezeeuw