acolytec3

Results 215 comments of acolytec3

One additional note is these tests only apply to the PoA/PoW miner functionality. In PoS networks, the `miner` class is completely unused and instead the `pendingBlock` class is used to...

Should we keep this open? We aren't passing all the hive tests yet but we've made a lot of progress since this was opened and would be worth either opening...

What issue are you having?

Are you using this in browser? Those look like polyfills for NodeJS builtin modules used by this library and we wouldn't include those in our `package.json` since this library doesn't...

@Parth2412 just checking in, are you able to address the review questions?

Going to close for now as no follow-up.

This gets resolved in vitest 1.5.2 so if we can figure out how to update vitest to a later version and it all work in #3369 , this can be...

It's a pretty trivial addition as we already have the code for it (I think in `block`). Just need to expose it via the rpc. I just need to take...

@roninjin10 PR in flight. It's pretty trivial but might do some additional test cleanup before we merge. But this gives you an idea of how to implement it using our...

What version of `@ethereumjs/tx` are you using? The one thing that jumps out to me is you're calling `toString` on the result of `signedTx.serialize`. Unless you're on an older version...