acolytec3

> There is something which I keep noticing, and keep getting confused about: > > https://github.com/ethereumjs/ethereumjs-monorepo/blob/d8f7544bf86231781b178f936459d96ddaf3e3a1/packages/vm/src/runTx.ts#L264-L267 > > This is NOT the base fee as in EIP-1559, but it is...

I haven't looked at what other clients populate within their metrics. What would be a useful starting point for identifying what metrics would be helpful?

> Just revisting this here, cannot completely remember, what was the status of this? > > Did I kill this off preliminary by being too sceptical about it? 😬 Or...

This test fails intermittently even on normal CI runs. I've thought about looking into this more but haven't had a chance. An ideal solution would be event based rather than...

In looking further at this test, this looks like a prime candidate for moving from `td` to `vitest.mock` for mocking. At the same time we ought to be able to...

Changes I have made to the original PR - Add a new CLI flag for `prometheusPort` - Moved `prometheusMetrics` to a new optional property on the `config` object that is...

Have gone through and updates this based on current master. Everything passes (most of the time) locally. I still get seemingly random errors like this for browser tests so still...

One interesting thing I found is that we do not need to alias `events` to `eventemitter3` and that actually introduces new problems. Have removed that from my attempts for now.

So we're down to `wallet` tests failing because of timeouts (they pass locally but are really slow on CI) and then the random failures I described above where browser tests...

I'm a big fan of collapsing the peer classes. That said, I would go with the class name `Peer` and not `RlpxPeer`. In our idealized future state, we won't have...