Akash Chetty

Results 14 comments of Akash Chetty
trafficstars

Let's not push rudder transformer changes in here.

Let's try to separate out logging actions and SQL statements. We have seen in the past that adding too many SQL statements in logs unnecessarily make it not much searchable.

Most of the comments are not following Go standards. Please follow [this](https://go.dev/blog/godoc).

Let's enrich the error where ever possible instead of just returning it back. It will help in debugging.

Let's using context for all the warehouse jobsdb calls. It it can either application context or it can be runner context or it can be context.TODO().

Sorry, @v-chojas. I added the description incorrectly. It's working with 4.0.32. Not working with the current released version 4.0.34

> Check where your odbcinst.ini is. 4.0.34 came with its own version of unixODBC which might not be looking for the odbcinst.ini in the same place as the one you...

Depending upon the rudder server features settings. https://github.com/rudderlabs/rudder-server/pull/2377

Moved this changes to [here](https://github.com/rudderlabs/rudder-server/pull/2732).

Since we are going with [this](https://github.com/rudderlabs/rudder-server/pull/4596) changes, closing the PR.