rudder-server icon indicating copy to clipboard operation
rudder-server copied to clipboard

chore(warehouse): syncs issues for no uploads present

Open achettyiitr opened this issue 3 years ago • 1 comments

Description

  • Handle no syncs case when the warehouse tries to merge existing syncs with the new ones thereby users do not get the existing syncs and we are sending a 204 response code to handle it.
  • Come code cleanup around the warehouse Grpc.

Notion Ticket

https://www.notion.so/rudderstacks/Syncs-dashboard-fixes-4d3c454856d844e09cc15a73012a37e1

Security

  • [x] The code changed/added as part of this pull request won't create any security issues with how the software is being used.

achettyiitr avatar Sep 07 '22 16:09 achettyiitr

Codecov Report

Base: 45.46% // Head: 45.48% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (baf7660) compared to base (52d9392). Patch coverage: 72.97% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
+ Coverage   45.46%   45.48%   +0.02%     
==========================================
  Files         290      290              
  Lines       48045    48089      +44     
==========================================
+ Hits        21842    21875      +33     
- Misses      24816    24826      +10     
- Partials     1387     1388       +1     
Impacted Files Coverage Δ
warehouse/api.go 69.69% <71.01%> (-0.49%) :arrow_down:
warehouse/warehousegrpc.go 76.69% <100.00%> (+0.91%) :arrow_up:
warehouse/schema.go 51.42% <0.00%> (+1.14%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 08 '22 03:09 codecov[bot]

This PR is considered to be stale. It has been open 20 days with no further activity thus it is going to be closed in 5 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR.

github-actions[bot] avatar Oct 05 '22 02:10 github-actions[bot]

Moved this changes to here.

achettyiitr avatar Nov 24 '22 06:11 achettyiitr