Yingchun Lai

Results 153 comments of Yingchun Lai

> > @ninsmiracle Thanks for the contribution! > > This pull request mention "slog" but I didn't see how does slog been operated in the patch, could you please describe...

Hi @gangliao, Thank you for the pull request. The Kudu project doesn't merge new code through GitHub PRs; we use the [gerrit](https://gerrit.cloudera.org/q/status:open%20project:kudu) tool to do code review and submission. Could...

@lengyuexuexuan Please check the failed CIs, for `Check License`, you need to add the new files to `.licenserc.yaml`.

Now that the go files have been pre-generated, the generate steps in https://github.com/apache/incubator-pegasus/blob/master/go-client/Makefile#L19 can be removed, right? Then you need to add the manual generate steps in `go-client/README.md`. And more,...

> > Now that the go files have been pre-generated, the generate steps in https://github.com/apache/incubator-pegasus/blob/master/go-client/Makefile#L19 can be removed, right? Then you need to add the manual generate steps in `go-client/README.md`....

Would it better to add an option to decide whether to gather such info or not?

@gp1314 A new version https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208 has been released, how about bumping to the newer version?

What's the relationship between the newly added config and `duplicate_log_batch_bytes`?