incubator-pegasus icon indicating copy to clipboard operation
incubator-pegasus copied to clipboard
verified publisher icon apache

fix(duplication): fix plog gc crash

Open ninsmiracle opened this issue 2 years ago • 3 comments

What problem does this PR solve?

#1596

What is changed and how does it work?

Add a parameter to protect a plog avoid from gc when it's been checking by duplication.

Tests
  • Unit test -cluster test

ninsmiracle avatar Sep 01 '23 11:09 ninsmiracle

@ninsmiracle Thanks for the contribution!

This pull request mention "slog" but I didn't see how does slog been operated in the patch, could you please describe the relationship? Thanks!

acelyc111 avatar Sep 12 '23 14:09 acelyc111

@ninsmiracle Thanks for the contribution!

This pull request mention "slog" but I didn't see how does slog been operated in the patch, could you please describe the relationship? Thanks!

In my opinion, this PR should called "plog gc crash",however in our inside gitlab repository,this commit called this name.I guess it's may be related to old version Slog ? But I'm not familiar with old version pegasus. So could I change the PR's name?

ninsmiracle avatar Sep 13 '23 07:09 ninsmiracle

@ninsmiracle Thanks for the contribution! This pull request mention "slog" but I didn't see how does slog been operated in the patch, could you please describe the relationship? Thanks!

In my opinion, this PR should called "plog gc crash",however in our inside gitlab repository,this commit called this name.I guess it's may be related to old version Slog ? But I'm not familiar with old version pegasus. So could I change the PR's name?

Feel free to rename.

acelyc111 avatar Sep 19 '23 11:09 acelyc111